More proper default value for namespace in K8S cleanup-pods CLI #15060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the default value for namespace is always 'default',
However, `conf.get('kubernetes', 'namespace')` may be a more proper
default value for namespace in this case
XD-DENG
added
area:CLI
type:improvement
mik-laj
approved these changes
Mar 28, 2021
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
kaxil
approved these changes
Mar 28, 2021
ashb
pushed a commit
that referenced
this pull request
Apr 1, 2021
Currently the default value for namespace is always 'default'.
However, `conf.get('kubernetes', 'namespace')` may be a more proper
default value for namespace in this case
(cherry picked from commit b8cf46a)
ashb
pushed a commit
that referenced
this pull request
Apr 15, 2021
Currently the default value for namespace is always 'default'.
However, `conf.get('kubernetes', 'namespace')` may be a more proper
default value for namespace in this case
(cherry picked from commit b8cf46a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the default value for namespace is always
'default'.However,
conf.get('kubernetes', 'namespace')may be a more proper default value for namespace here (because users may have specified a different default namespace for K8S in configuration).^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.