Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timezone context in new ui #15096

Merged
merged 4 commits into from
Mar 31, 2021

Conversation

bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Mar 30, 2021

Adding a context provider to handle what timezone to use in the new UI.

The order of operations is:=

  1. local timezone of the browser
  2. fall back to UTC
  • we plan to add a GET /ui-metadata endpoint to act as the primary source of truth. that will be put in when the API is ready

Closes #14806

This is just for display purposes. Any changes by the user will be handled in #14807

  • created a /providers directory and moved auth there too
  • we were originally going to use /config for the default_timezone but then removed it in favor of /ui-metadata. But we're leaving the config hook and interfaces in there because it will be useful later.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Mar 30, 2021
Copy link
Contributor

@ryanahamilton ryanahamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Mar 30, 2021
@ryanahamilton ryanahamilton merged commit 88a7444 into apache:master Mar 31, 2021
@ryanahamilton ryanahamilton deleted the timezone-provider branch March 31, 2021 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure App Timezone provider and display utilities
2 participants