Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Helm Chart doc enhancements #15124

Merged
merged 2 commits into from
Apr 2, 2021
Merged

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Apr 1, 2021

  • Better formatting for tip
  • Correct listing

Before:

image

image

After:

image

image

Part of #14303


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

- Better formatting for `tip`
- Correct listing
@github-actions
Copy link

github-actions bot commented Apr 1, 2021

The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Apr 1, 2021
@ephraimbuddy
Copy link
Contributor

There's a little mistake on the quickstart.rst https://github.com/apache/airflow/blob/master/docs/helm-chart/quick-start.rst for installing a release:
helm install airflow --n airflow . should be
helm install airflow -n airflow .

Wondering if we can add it to this PR?

@kaxil kaxil merged commit 2ac4638 into apache:master Apr 2, 2021
@kaxil kaxil deleted the minor-doc-enhacement branch April 2, 2021 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:documentation okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants