Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix password masking in CLI action_logging #15143

Merged
merged 3 commits into from
Apr 1, 2021
Merged

Fix password masking in CLI action_logging #15143

merged 3 commits into from
Apr 1, 2021

Commits on Apr 1, 2021

  1. Fix password masking in CLI action_logging 

    Currently as long as argument '-p' if present, code tries to mask it.

However, '-p' may mean something else (not password), like a boolean flag. Such cases may result in exception
    @XD-DENG
    XD-DENG committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    fbd7ea2 View commit details
    Browse the repository at this point in the history

  2. Add test cases

    @XD-DENG
    XD-DENG committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    6b1f641 View commit details
    Browse the repository at this point in the history

  3. Add clarification for the test cases

    @XD-DENG
    XD-DENG committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    c022907 View commit details
    Browse the repository at this point in the history