Fix missing on_load trigger for folder-based plugins #15208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedcunningham
commented
Apr 5, 2021
| :param plugin_instance: subclass of AirflowPlugin | ||
| """ | ||
| global plugins # pylint: disable=global-statement | ||
| plugin_instance.on_load() |
There was a problem hiding this comment.
We don't need to check if on_load is present since we already verify the plugin is a subclass of AirflowPlugin.
mik-laj
approved these changes
Apr 5, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
Co-authored-by: Jed Cunningham <[email protected]>
jedcunningham
force-pushed
the
plugin_manager_onload_fix
branch
from
a07fbd6
to
4d51214
Compare
|
@mik-laj, can this be added to the next bugfix milestone (2.0.2 or 2.0.3)? Just want to make sure it doesn't get missed. |
ashb
pushed a commit
that referenced
this pull request
Apr 15, 2021
(cherry picked from commit 97b7780)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is resurrecting #10878 by @maiorBoltach, slightly simplified and with more comprehensive test coverage.
Method 'on_load' should run on plugins initialization, that are located in plugin folder.
Before method was triggered only for plugins in airflow.plugins.* entry points
closes: #10868