Finish refactor of DAG resource name helper #15511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedcunningham
requested review from
ashb,
jhtimmins,
kaxil,
turbaszek and
XD-DENG
as code owners
jedcunningham
commented
Apr 23, 2021
| @@ -63,8 +63,8 @@ | |||
| DAG_PERMS = {ACTION_CAN_READ, ACTION_CAN_EDIT} | |||
|
|
|||
|
|
|||
| def permission_name_for_dag(dag_id): | |||
| """Returns the permission name for a DAG id.""" | |||
| def resource_name_for_dag(dag_id): | |||
There was a problem hiding this comment.
This is the right name for this, pretty sure. Input @jhtimmins?
kaxil
approved these changes
Apr 26, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 26, 2021
This finishes moving `prefixed_dag_id` into `airflow.security.permissions.resource_name_for_dag`. (cherry picked from commit 0b4c67d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes moving
prefixed_dag_idintoairflow.security.permissions.resource_name_for_dag.