Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mask passwords and sensitive info in task logs and UI #15599

Merged
merged 5 commits into from
May 5, 2021
Merged

Mask passwords and sensitive info in task logs and UI #15599

merged 5 commits into from
May 5, 2021

Commits on May 4, 2021

  1. Add a logging filter to mask secrets from logs 

    This isn't used anywhere yet, but it is the first step in not printing
passwords in the logs
    @ashb
    ashb committed May 4, 2021
    Configuration menu
    Copy the full SHA
    b7b2e4a View commit details
    Browse the repository at this point in the history

  2. Mask secret values from connections and variables 

    This masks secret values in logs for Connections and Variables.

It behaves as follows:

- Connection passwords are always masked, where-ever they appear.

  This means, if a connection has a password of `a`, then _every_ `a` in
  log messages would get replaced with `***`

- "Sensitive" keys from extra_dejson are also masked. Sensitive is
  defined by the "existing" mechanism that the UI used, based upon the
  name of the key.

- "Sensitive" Variables are also masked.
    @ashb
    ashb committed May 4, 2021
    Configuration menu
    Copy the full SHA
    7d7b2da View commit details
    Browse the repository at this point in the history

  3. fixup! Mask secret values from connections and variables

    @ashb
    ashb committed May 4, 2021
    Configuration menu
    Copy the full SHA
    3c6e356 View commit details
    Browse the repository at this point in the history

  4. fixup! Mask secret values from connections and variables

    @ashb
    ashb committed May 4, 2021
    Configuration menu
    Copy the full SHA
    387978d View commit details
    Browse the repository at this point in the history

  5. fixup! Mask secret values from connections and variables

    @ashb
    ashb committed May 4, 2021
    Configuration menu
    Copy the full SHA
    46bfe95 View commit details
    Browse the repository at this point in the history