Fix import order for task_instance_mutation_hook #15851
Conversation
| @@ -41,7 +41,6 @@ | |||
| from airflow.exceptions import AirflowException, TaskNotFound | |||
| from airflow.models.base import ID_LEN, Base | |||
| from airflow.models.taskinstance import TaskInstance as TI | |||
There was a problem hiding this comment.
| from airflow.models.taskinstance import TaskInstance as TI | |
| from airflow.models.taskinstance import TaskInstance as TI | |
| from airflow.settings import task_instance_mutation_hook |
There was a problem hiding this comment.
The fix is to quite literally delay the import, to avoid an import cycle.
At the point this was imported, the local settings hadn't been applied, so this was always going to be a no-op.
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
|
Can you rebase on latest master please? |
Done. |
|
@jhtimmins I'm just about to merge this h we need to make sure we include it in 2.1 |
Fixed #15698
import from
airflow.models.dagrunmodule may causetask_instance_mutation_hookto be overwritten.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.