-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: AwsGlueJobOperator change order of args for load_file #16216
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
Can you change the code to use keyword arguments instead? This will help prevent bugs in the future when the hook is changed. |
👍 ✅ |
s3_hook.load_file( | ||
filename=self.script_location, | ||
key=self.s3_artifacts_prefix + script_name, | ||
bucket_name=self.s3_bucket, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this. would it be possible to also add an argument to replace if the file exists, which is the replace
argument?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I will merge it as is as we are releasing providers tomorrow/Monday. This might be a separate feature.
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
1 similar comment
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Awesome work, congrats on your first merged pull request! |
As far as I understand the
load_file
function in the S3 hook expects key before bucket name.airflow/airflow/providers/amazon/aws/hooks/s3.py
Line 466 in d245992
The
AwsGlueJobOperator
currently calls theload_file
function withs3_bucket
beforekey
.airflow/airflow/providers/amazon/aws/operators/glue.py
Line 104 in d245992
This PR changes that order to comply with the order of
load_file