Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make job name check optional in SageMakerTrainingOperator #16327

Merged

Conversation

olivermeyer
Copy link
Contributor

closes: #16299

In this PR I make it possible to avoid listing existing training jobs by adding a check_if_job_exists parameter to the SageMakerTrainingOperator.

@boring-cyborg boring-cyborg bot added area:providers provider:amazon-aws AWS/Amazon - related issues labels Jun 8, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 8, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@olivermeyer olivermeyer force-pushed the make-sagemaker-training-job-check-optional branch from f458b3f to 27703db Compare June 8, 2021 15:02
@eladkal eladkal requested a review from feluelle June 8, 2021 17:57
@olivermeyer olivermeyer reopened this Jun 10, 2021
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jun 10, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@olivermeyer
Copy link
Contributor Author

@kaxil thanks for reviewing. Is there anything else I need to do to get this merged?

@kaxil kaxil merged commit 36dc6a8 into apache:main Jun 16, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 16, 2021

Awesome work, congrats on your first merged pull request!

@kaxil
Copy link
Member

kaxil commented Jun 16, 2021

Nope, all good @olivermeyer 👏

@olivermeyer olivermeyer deleted the make-sagemaker-training-job-check-optional branch June 17, 2021 06:58
@shlomiken
Copy link

thanks for this @olivermeyer , is there any plans doing that for processingJob /transformJob as well ?
i considered doing that myself - but i guess the kick start develop in this repo is not so quick is it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SageMakerTrainingOperator gets ThrottlingException when listing training jobs
3 participants