Chart: refactor webserver and flower networkpolicy #16619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
approved these changes
Jun 23, 2021
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
jedcunningham
force-pushed
the
networkpolicy_sidecar
branch
from
d92280d
to
90377ee
Compare
This adds support for overriding ports on the webserver and flower networkpolicies. This allows sidecars with webservers in them to function when networkpolicy is enabled. This also renamed the existing parameter used to define `from` in the networkpolicies ingress.
jedcunningham
force-pushed
the
networkpolicy_sidecar
branch
from
90377ee
to
74d05fb
Compare
|
Merging as I can't get the already flaky helm chart tests to pass. |
|
Yeah. I think something has changed recently that made the test to timeout I saw it a number of times. I will take a look tomorrow to see if I can figure it out. |
|
Issue created #16736 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for overriding ports on the webserver and flower
networkpolicies. This allows sidecars with webservers in them to
function when networkpolicy is enabled.
This also renamed the existing parameter used to define
fromin the networkpolicies ingress.