Add support for managed identity in WASB hook #16628
Conversation
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
| return BlobServiceClient( | ||
| account_url=f"https://{conn.login}.blob.core.windows.net/", | ||
| credential=conn.password or ManagedIdentityCredential(), | ||
| credential=conn.password, |
There was a problem hiding this comment.
Well. For me this one looks like it REMOVES the MIC support. From what I see, the previous code worked in the way this PR intended to (if conn.password = None, then managedidentity credential was created and used. This PR makes the credential created but not used. Did I miss something?
There was a problem hiding this comment.
Should it be
| credential=conn.password, | |
| credential=credential, |
But then it is just adding an extra log entry in case the MIC is used.
There was a problem hiding this comment.
Of course – fixed. Nice catch
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
malthe
force-pushed
the
wasb-add-managed-identity-support
branch
from
0fd9442
to
8e00912
Compare
malthe
force-pushed
the
wasb-add-managed-identity-support
branch
from
8e00912
to
79781ba
Compare
|
@potiuk should be good now |
|
Cool! Merged! |
This adds support for managed identity credential in case a password (or one of the other means of authentication) is not provided.
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.