-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New generic tableau operator: TableauOperator #16915
Conversation
Added generic tableau operator to execute multiple methods on python client
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left comments in the code.
Note that also requires tests for TableauOperator
airflow/providers/tableau/operators/tableau_refresh_workbook.py
Outdated
Show resolved
Hide resolved
- Fixed documentation comments on TableauOperator execute - Added generic find by column - Deprecated TableauRefreshWorkbookOperator
airflow/providers/tableau/operators/tableau_refresh_workbook.py
Outdated
Show resolved
Hide resolved
@mariotaddeucci we just merged #16916 can you please rebase and fix conflicts? |
Added generic tableau operator to execute multiple methods on python client
- Fixed documentation comments on TableauOperator execute - Added generic find by column - Deprecated TableauRefreshWorkbookOperator
Static checks and docs are still failing I am afraid. |
@eladkal the last commit haven't passed on on |
New dependency was added by new provider and you need to rebase to get it working I am afraid :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (left one comment on but it's not that important)
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Awesome work, congrats on your first merged pull request! |
Woohoo! |
Added an generic tableau operator to execute multiple methods on python client.