Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds option to disable mounting temporary folder in DockerOperator #16932

Merged
merged 3 commits into from
Jul 15, 2021

Commits on Jul 14, 2021

  1. Adds option to disable mounting temporary folder in DockerOperator

    The DockerOperator by default mounts temporary folder to inside
    the container in order to allow to store files bigger than
    default size of disk for the container, however this did not work
    when remote Docker engine or Docker-In-Docker solution was used.
    
    This worked before the apache#15843 change, because the /tmp has
    been ignored, however when we change to "Mounts", the "/tmp"
    mount fails when using remote docker engine.
    
    This PR adds parameter that allows to disable this temporary
    directory mounting (and adds a note that it can be replaced
    with mounting existing volumes). Also it prints a warning
    if the directory cannot be mounted and attempts to re-run
    such failed attempt without mounting the temporary
    directory which brings back backwards-compatible behaviour
    for remote engines and docker-in-docker.
    
    Fixes: apache#16803
    Fixes: apache#16806
    potiuk committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    e36f703 View commit details
    Browse the repository at this point in the history
  2. Update airflow/providers/docker/operators/docker.py

    Co-authored-by: Akshesh Doshi <[email protected]>
    potiuk and akki authored Jul 14, 2021
    Configuration menu
    Copy the full SHA
    b86685a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d3ad29e View commit details
    Browse the repository at this point in the history