Errors out instead of trying to workaround buggy docker-compose v2 #16989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the error printed now (of course changed to 2 version in the commit): |
potiuk
force-pushed
the
remove-docker-compose-2-hack
branch
from
f94f004
to
0c622ad
Compare
|
Triggering the build after constraints update (kms causes problems). |
Docker-Compose v2 Beta has an error in processing environment variable file which prevents Breeze from running. Until it is fixed, we are going to print an error, explain how to disable it and exit - because the workaround introduces more problems than it solves (passing environment variables to container is broken partially) Also see docker-archive/compose-cli#1917
potiuk
force-pushed
the
remove-docker-compose-2-hack
branch
from
0c622ad
to
0efe94f
Compare
eladkal
approved these changes
Jul 14, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
|
I merge it - there's something wrong with KMS tests still, but I believe I know the reason and fix it separately. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jul 16, 2021
The docker-compose v2 parsing of env file bug detected in apache#16949 and eventual disabling of docker-compose-v2 in apache#16989 found another workaround after discussing with docker-compose maintainers in docker-archive/compose-cli#1917 The VAR=${VAR} pattern seems to work for all cases for Airflow because we never rely on the fact if variable is set or not - we always take into account value of the variable (that is by design and strictly followed everywhere). Therefore we are sure this workaround is going to work for us. However we should remove that workaround once the bug is fixed in Docker-Compose V2.
potiuk
added a commit
that referenced
this pull request
Jul 18, 2021
…16989) Docker-Compose v2 Beta has an error in processing environment variable file which prevents Breeze from running. Until it is fixed, we are going to print an error, explain how to disable it and exit - because the workaround introduces more problems than it solves (passing environment variables to container is broken partially) Also see docker-archive/compose-cli#1917 (cherry picked from commit 97ae0f2)
josh-fell
pushed a commit
to josh-fell/airflow
that referenced
this pull request
Jul 19, 2021
…pache#16989) Docker-Compose v2 Beta has an error in processing environment variable file which prevents Breeze from running. Until it is fixed, we are going to print an error, explain how to disable it and exit - because the workaround introduces more problems than it solves (passing environment variables to container is broken partially) Also see docker-archive/compose-cli#1917
kaxil
pushed a commit
that referenced
this pull request
Aug 17, 2021
…16989) Docker-Compose v2 Beta has an error in processing environment variable file which prevents Breeze from running. Until it is fixed, we are going to print an error, explain how to disable it and exit - because the workaround introduces more problems than it solves (passing environment variables to container is broken partially) Also see docker-archive/compose-cli#1917 (cherry picked from commit 97ae0f2)
jhtimmins
pushed a commit
that referenced
this pull request
Aug 17, 2021
…16989) Docker-Compose v2 Beta has an error in processing environment variable file which prevents Breeze from running. Until it is fixed, we are going to print an error, explain how to disable it and exit - because the workaround introduces more problems than it solves (passing environment variables to container is broken partially) Also see docker-archive/compose-cli#1917 (cherry picked from commit 97ae0f2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker-Compose v2 Beta has an error in processing environment
variable file which prevents Breeze from running. Until it is
fixed, we are going to print an error, explain how to disable
it and exit - because the workaround introduces more problems
than it solves (passing environment variables to container
is broken partially)
Also see docker-archive/compose-cli#1917
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.