Update version added fields in airflow/config_templates/config.yml #18128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mik-laj
commented
Sep 9, 2021
| @@ -454,23 +454,23 @@ | |||
| description: | | |||
| The folder where airflow should store its log files | |||
| This path must be absolute | |||
| version_added: ~ | |||
| version_added: 2.0.0 | |||
There was a problem hiding this comment.
All logging configuration options have been moved to a new section in Airflow 2.0, so they do not work on older versions.
mik-laj
commented
Sep 9, 2021
| @@ -628,25 +628,25 @@ | |||
| - name: statsd_on | |||
| description: | | |||
| Enables sending metrics to StatsD. | |||
| version_added: ~ | |||
| version_added: 2.0.0 | |||
There was a problem hiding this comment.
All metrics configuration options have been moved to a new section in Airflow 2.0, so they do not work on older versions.
mik-laj
commented
Sep 9, 2021
| @@ -1635,7 +1635,7 @@ | |||
| - name: worker_precheck | |||
| description: | | |||
| Worker initialisation check to validate Metadata Database connection | |||
| version_added: 1.10.1 | |||
| version_added: 2.0.0 | |||
There was a problem hiding this comment.
Option has been moved from core to celery.
kaxil
approved these changes
Sep 9, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have looked at all the fields carefully and noticed a few problems that I would like to correct. I used the script I wrote to check in what version the options were added.
https://gist.github.com/mik-laj/d3b3bd4d024fb5f7a563423a514e62a1
Related: #18110
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.