Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize dockerfiles builds #19327

Merged
merged 6 commits into from
Nov 1, 2021
Merged

Modernize dockerfiles builds #19327

merged 6 commits into from
Nov 1, 2021

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Oct 30, 2021

I did the following changes:

  • Bash code style unification (readonly variables, variable name convention)
  • To build pgbouncer-exporter/Dockerfile, use multi-stage to simplify the building process and make it even more independent from the system
  • Add a simple coherence check to improve confidence

CC: @pgvishnuram


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@pgvishnuram
Copy link
Contributor

@mik-laj - would prefer to run the service as non root by default

@mik-laj
Copy link
Member Author

mik-laj commented Oct 30, 2021

Non-root will be nice, but in this PR I just wanted to refactor the code without changing the behavior.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Oct 30, 2021
@mik-laj mik-laj merged commit ddcc848 into apache:main Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart area:production-image Production image improvements and fixes okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants