Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsitencies in checking edit permissions for a DAG #20346

Merged
merged 3 commits into from
Jan 14, 2023
Merged

Fix inconsitencies in checking edit permissions for a DAG #20346

merged 3 commits into from
Jan 14, 2023

Commits on Jan 14, 2023

  1. Fix inconsitencies in checking edit permissions for a DAG 

    We were short-circuting permission in the views instead of letting the security manager handle that. A user will find it inconsistent as the Graph and other views check "per-dag" permissions via https://github.com/apache/airflow/blob/174681911f96f17d41a4f560ca08d5e200944f7f/airflow/www/views.py#L579

so if someone uses Custom Security Manager that will end up with user not being able to "pause" DAG from individual dag page but would be able to do so from Homepage. This PR fixes this inconsistency and gives back this responsibility of permissions to security manager instead if Views.
    @kaxil
    kaxil committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    f0461da View commit details
    Browse the repository at this point in the history

  2. Add generic all read and all edit function

    @kaxil
    kaxil committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    cf73c84 View commit details
    Browse the repository at this point in the history

  3. fixup! Add generic all read and all edit function

    @kaxil
    kaxil committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    f934c79 View commit details
    Browse the repository at this point in the history