Do not fail requeued TIs #23846
Merged
Do not fail requeued TIs #23846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:Scheduler
uranusjr
reviewed
May 23, 2022
2 tasks
|
But need others confirmation too |
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
|
Anyone? |
|
Taking a look. |
ashb
reviewed
Jun 6, 2022
ashb
reviewed
Jun 6, 2022
Co-authored-by: Tzu-ping Chung <[email protected]>
tanelk
commented
Jun 20, 2022
Comment on lines
+404
to
+416
| # ti is queued with another try number - do not fail it | ||
| ti1.state = State.QUEUED | ||
| ti1.queued_by_job_id = 1 | ||
| ti1.try_number = 2 | ||
| session.merge(ti1) | ||
| session.commit() | ||
|
|
||
| executor.event_buffer[ti1.key.with_try_number(1)] = State.SUCCESS, None | ||
|
|
||
| self.scheduler_job._process_executor_events(session=session) | ||
| ti1.refresh_from_db(session=session) | ||
| assert ti1.state == State.QUEUED | ||
| self.scheduler_job.executor.callback_sink.send.assert_not_called() |
There was a problem hiding this comment.
Rebased a this should check try number handling
jedcunningham
approved these changes
Jun 28, 2022
ephraimbuddy
pushed a commit
that referenced
this pull request
Jun 29, 2022
(cherry picked from commit 66ffe39)
This was referenced Jul 2, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By the time time we process executor events we might have requeued the TI - we should not mark the TI failed in this case.
One way this can happen is deferable operator with quick trigger.
closes: #23824
related: #21316
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.