Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better diagnostics capabilities for pre-commits run via CI image #23980

Merged

Commits on May 28, 2022

  1. Add better diagnostics capabilities for pre-commits run via CI image

    The pre-commits that require CI image run docker command under
    the hood that is highly optimized for performance (only mounts
    files that are necessary to be mounted) - in order to improve
    performance on Mac OS and make sure that artifacts are not left
    in the source code of Airflow.
    
    However that makes the command slightly more difficult to debug
    because they generate dynamically the docker command used,
    including the volumens that should be mounted when the docker
    command is run.
    
    This PR adds better diagnostics to the pre-commit scripts
    allowing VERBOSE="true" and DRY_RUN="true" variables that can
    help with diagnosing problems such as running the scripts on
    WSL2.
    
    It also fixes a few documentation bugs that have been missed
    after changing names of the image-related static checks and
    thanks to separating the common code to utility function
    it allows to set SKIP_IMAGE_PRE_COMMITS variable to true
    which will skip running all pre-commit checks that require
    breeze image to be available locally.
    potiuk committed May 28, 2022
    Configuration menu
    Copy the full SHA
    7798d06 View commit details
    Browse the repository at this point in the history