Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Google calendar example DAG to new design AIP-47 #24333

Merged
merged 1 commit into from
Jun 12, 2022
Merged

Migrate Google calendar example DAG to new design AIP-47 #24333

merged 1 commit into from
Jun 12, 2022

Conversation

chenglongyan
Copy link
Contributor

related: #22447


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member

potiuk commented Jun 11, 2022

@chenglongyan -> I have just solved a problem where "[source]" links were missing and there are two things to add to make it works. Once I merge #24386 you will get errors for those missing parts, but maybe you can add them now:

  1. __init__.py should be added for all folders in path of "tests/system/...../example*.py" so that the packages created are not "implicit" namespace packages
  2. System Tests <_api/tests/system/providers/google/../index> link needs to be added to index to avoid "missing index in TOC tree"

Not sure if you need to do it (not sure if you create any empty directory here), but I'd recommend to rebase on top of my change and fix all problems - I hope to have my change merged soon.

@potiuk
Copy link
Member

potiuk commented Jun 12, 2022

I will merge it and fix in bulk.

@potiuk potiuk merged commit 6eb60f8 into apache:main Jun 12, 2022
@chenglongyan chenglongyan deleted the example_calendar_to_gcs branch June 20, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers kind:documentation provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants