-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendor in the bitnami chart #24395
Merged
Merged
Vendor in the bitnami chart #24395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
ashb,
mik-laj,
dstandish and
jedcunningham
as code owners
June 11, 2022 20:50
potiuk
force-pushed
the
vendor-in-postgres-chart
branch
2 times, most recently
from
June 11, 2022 21:32
638479c
to
18ddf21
Compare
After the Bitnami fiasco bitnami/charts#10539 We lost trust in bitnami index being good and reliable source of charts. That's why we vendored-in the postgres chart needed for our Helm chart. Fixes: apache#24037
potiuk
force-pushed
the
vendor-in-postgres-chart
branch
from
June 11, 2022 21:34
18ddf21
to
23f9f72
Compare
That should also speed up K8S tests |
:) @jedcunningham ? |
jedcunningham
approved these changes
Jun 14, 2022
github-actions
bot
added
the
full tests needed
We need to run full set of tests for this PR to merge
label
Jun 14, 2022
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
6 tasks
ephraimbuddy
added
the
type:misc/internal
Changelog: Misc changes that should appear in change log
label
Aug 14, 2022
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:dev-tools
area:helm-chart
Airflow Helm Chart
full tests needed
We need to run full set of tests for this PR to merge
type:misc/internal
Changelog: Misc changes that should appear in change log
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the Bitnami fiasco
bitnami/charts#10539
We lost trust in bitnami index being good and reliable source
of charts. That's why we vendored-in the postgres chart needed for
our Helm chart.
Fixes: #24037
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst
, in newsfragments.