Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fixture for CLI tests requiring sample dags #26536

Merged
merged 4 commits into from
Sep 21, 2022
Merged

Add fixture for CLI tests requiring sample dags #26536

merged 4 commits into from
Sep 21, 2022

Commits on Sep 21, 2022

  1. Add fixture for CLI tests requiring sample dags 

    I noticed that various CLI tests were failing (specifically in test_task_command.py) when run locally but not when run in breeze.  I figured out the cause is that breeze has ('core', 'load_examples') set to true but I had it false locally.  To fix this we can add a fixture that patches the conf settings.  But we have to go one step further.  If we grab the conf value in the default for the argument in DagBag, this means the value is fixed at the time the class gets defined.  So the value cannot be changed later in runtime!  The solution is to resolve the default on the fly each time an instance is created.

We do the same for safe_mode while we're at it, because why not.
    @dstandish
    dstandish committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    9ac093c View commit details
    Browse the repository at this point in the history

  2. do for safe mode

    @dstandish
    dstandish committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    0004357 View commit details
    Browse the repository at this point in the history

  3. fix tests -- they were dependent on the old non-dynamic default behavior

    @dstandish
    dstandish committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    9928797 View commit details
    Browse the repository at this point in the history

  4. fix mypy

    @dstandish
    dstandish committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    0189669 View commit details
    Browse the repository at this point in the history