Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selective checks handling error tracebacks in CI #28514

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Fix selective checks handling error tracebacks in CI #28514

merged 1 commit into from
Dec 21, 2022

Commits on Dec 21, 2022

  1. Fix selective checks handling error tracebacks in CI 

    Initially selective check was implemented in the way that it printed
diagnostic output on stdout and the GITHUB_OUTPUT compatible set of
outputs on stderr so that it could be redirected to the GITHUB_OUTPUT
in its entirety. But this turned out to be a bad idea because when
there was an error generated in selective-checks themselves, the
traceback was printed in stderr and redirecting stderr to GITHUB_OUTPUT
swallowed the traceback.

This change reverses the behaviour:

* diagnostic output is printed to stderr
* GITHUB_OUTPUT compatible output is printed to stdout

This way when traceback happens it is printed to stderr and is not
swalleowed by redirection to GITHUB_OUTPUT
    @potiuk
    potiuk committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    6719a53 View commit details
    Browse the repository at this point in the history