Provide more context for trigger_reason in DbtCloudRunJobOperator
#28994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users may be confused when comparing the dbt API and the Python API docs for the DbtCloudRunJobOperator re: to `trigger_reason`. This value is required for the dbt API but not for the operator. The operator will handle providing a default value. Adding the default value in the `trigger_reason` param docstring so users have additional context when reading the Python API doc for the operator.
Taragolis
approved these changes
Jan 17, 2023
58 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users may be confused when comparing the dbt API and the Python API docs for the DbtCloudRunJobOperator re: to
trigger_reason. This value is required for the dbt API but not for the operator. The operator will handle providing a default value. Adding the default value in thetrigger_reasonparam docstring so users have additional context when reading the Python API doc for the operator.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.