Allow downloading of dbt Cloud artifacts to non-existent paths #29048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-fell
force-pushed
the
dbt-cloud-job-artifact
branch
from
7e3f668
to
d4fbb3e
Compare
|
Random failures. Nice addition and nice improvements in tests. |
potiuk
approved these changes
Jan 21, 2023
Closes: apache#27107 Currently the DbtCloudGetJobRunArtifactOperator does not support downloading dbt Cloud job run artifacts to non-existent local paths. This means users couldn't specify a dynamic file path to which to download the artifact. This PR will enhance the DbtCloudGetJobRunArtifactOperator to create these non-existent paths when necessary.
josh-fell
force-pushed
the
dbt-cloud-job-artifact
branch
from
d4fbb3e
to
dfcf4b9
Compare
|
Rebased and resolved conflicts. |
58 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #27107
Currently the DbtCloudGetJobRunArtifactOperator does not support downloading dbt Cloud job run artifacts to non-existent local paths. This means users couldn't specify a dynamic file path to which to download the artifact.
This PR will enhance the DbtCloudGetJobRunArtifactOperator to create these non-existent paths when necessary.
A little bonus of updated test coverage and pushing the task's
output_file_nametoXCom(which may be useful to then read said artifact).^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.