-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: type annotation for num_of_dpus
in GlueJobHook
#29176
Conversation
You also need to change in Operator (potentially in other places)
I still don't know what is better annotation for this case |
Yeah, statics check failed: airflow/providers/amazon/aws/hooks/glue.py:97: error: Incompatible types in
assignment (expression has type "float", variable has type "int") [assignment]
self.num_of_dpus = num_of_dpus |
5226f3d
to
c4c14c0
Compare
Ok @Taragolis. Adding in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending approval (wait for CI)
🤣 Add annotation here, something like: |
c4c14c0
to
f52a89a
Compare
7c2b962
to
5437a85
Compare
|
Awesome work, congrats on your first merged pull request! |
closes: #29091
Simple fix of type annotation for
num_of_dpus
according to AWS Glue Documentation@Taragolis may you please review this PR?