Restore trigger logging #29482
Merged
Restore trigger logging #29482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
dstandish
requested review from
eladkal,
o-nikolas,
ryanahamilton,
ashb,
bbovenzi,
ephraimbuddy,
potiuk,
jedcunningham,
kaxil and
XD-DENG
as code owners
XD-DENG
approved these changes
Feb 12, 2023
|
Ah.. Nice catch @dstandish :) |
pierrejeambrun
added
the
changelog:skip
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
May 23, 2023
After apache#29482 triggerer logs are not printed directly to the stdout, but they are queued in memory and written by a separate thread. This causes a slight flakiness in case of CI tests for test_trigger_job - especially on MSSQL. This simple workaround should give more time to the logs to propgate during the test
potiuk
added a commit
that referenced
this pull request
May 23, 2023
After #29482 triggerer logs are not printed directly to the stdout, but they are queued in memory and written by a separate thread. This causes a slight flakiness in case of CI tests for test_trigger_job - especially on MSSQL. This simple workaround should give more time to the logs to propgate during the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores trigger logging PR #27758 which was reverted (#29472) due to CI problems.
See commit 5e8aed9 for the fix.