Change log level of serialization information #30239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The apache#30094 introduced info log on how long serialization takes, and coupled with the fact that serialization register() function is called by just importing the serde module it caused a potential of breaking airflow CLI method that produce formatted output (with `--output` flag with json format). Those methods block warnings and logs, but only after initial CLI parsing is complete and the right CLI method is selected (with @suppress_logs_and_warnings). However in case serde module is imported before, default "info" log level might cause the log to be printed before it has been blocked. The log level seemed to be left here by mistake (it's not a good practice to log anything at import time), so changing it to debug seems appropriate.
This was referenced Mar 22, 2023
uranusjr
approved these changes
Mar 22, 2023
pierrejeambrun
added
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #30094 introduced info log on how long serialization takes, and coupled with the fact that serialization register() function is called by just importing the serde module it caused a potential of breaking airflow CLI method that produce formatted output (with
--outputflag with json format).Those methods block warnings and logs, but only after initial CLI parsing is complete and the right CLI method is selected (with @suppress_logs_and_warnings). However in case serde module is imported before, default "info" log level might cause the log to be printed before it has been blocked.
The log level seemed to be left here by mistake (it's not a good practice to log anything at import time), so changing it to debug seems appropriate.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.