AIP-56 - Create auth manager interface and very basic implementation of FAB auth manager #32217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincbeck
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:UI
uranusjr
reviewed
Jun 28, 2023
vandonr-amz
reviewed
Jun 28, 2023
| """ | ||
| Return the username associated to the user in session. | ||
|
|
||
| For backward compatibility reasons, the username in FAB auth manager is the concatenation of the |
There was a problem hiding this comment.
backward compatibility with what ? 🤔
There was a problem hiding this comment.
Current experience :)
There was a problem hiding this comment.
I can mention "legacy user management"
o-nikolas
reviewed
Jun 28, 2023
| @@ -1808,4 +1827,5 @@ def __getattr__(name): | |||
|
|
|||
| conf = initialize_config() | |||
| secrets_backend_list = initialize_secrets_backends() | |||
| auth_manager = initialize_auth_manager() | |||
There was a problem hiding this comment.
This module is already hugely dependent on a lot of other modules and very often creates import cycles. Does this have to be initialized here?
There was a problem hiding this comment.
The auth manager will be used in a lot of code/modules in Airflow. That's where I think it makes to more sense but I can move it if there is a better location to do so
|
Any comments/concerns/feedbacks? |
uranusjr
approved these changes
Jul 5, 2023
|
@potiuk , you might be interested in this one :) |
|
I think it's a great start ! |
potiuk
approved these changes
Jul 5, 2023
ephraimbuddy
added
the
changelog:skip
This was referenced Jul 6, 2023
This was referenced Aug 22, 2023
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates the core components of AIP-56:
To start off, we use the auth manager for a very simple use case: retrieving the user name to display it on the UI (on the top right corner).
Resolves #32188, #32189 and #32190
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.