Refactor: Simplify code in settings #33267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eumiro
force-pushed
the
settings
branch
3 times, most recently
from
0dadedf
to
cc41283
Compare
potiuk
reviewed
Aug 13, 2023
| @@ -465,11 +465,23 @@ def import_local_settings(): | |||
| """Import airflow_local_settings.py files to allow overriding any configs in settings.py file.""" | |||
| try: | |||
| import airflow_local_settings | |||
|
|
|||
| except ModuleNotFoundError as e: | |||
There was a problem hiding this comment.
Looks good - even if there are other import errors laters (it's possible - local imports for example) - then this code was anyhow re-raising them.
potiuk
approved these changes
Aug 13, 2023
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 17, 2023
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 28, 2023
(cherry picked from commit 95e9d83)
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.