Explain the users how they can check if python code is top-level #34006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many users have problem with it. Adding the way how they can check it easily.
eladkal
approved these changes
Sep 1, 2023
Comment on lines
+219
to
+222
| operator = PythonOperator( | ||
| task_id=get_task_id(), | ||
| python_callable=get_array, | ||
| dag=dag, |
There was a problem hiding this comment.
From what I gather from #33997 the confusion is more around templated parameters or parameters in general?
I wonder if the author question was more around this case:
operator = PythonOperator(
task_id=get_task_id(),
python_callable=get_array,
op_kwargs={"0": my_func()} # <- this one
dag=dag,
There was a problem hiding this comment.
Could be .. but the mechanism of checking it is the same. If they add print in my_func() they will also see it.
ephraimbuddy
pushed a commit
that referenced
this pull request
Sep 1, 2023
) Many users have problem with it. Adding the way how they can check it easily. (cherry picked from commit 9702a14)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many users have problem with it. Adding the way how they can check it easily.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.