Commits on Sep 4, 2023

1. Attempt to fix the flaky TestTriggererJob test …

   As documented in apache#33323, we have frequent failures of the flaky
   triggerer job tests.
   
   The flaky failures are about some errors when we close all the
   sessions in teardown of the test. It turns out that the tests
   had side-effect - they have not waited for the TriggererJob thread
   to complete, they merely marked them to be stopped, but they have
   not waited for those to complete - this is quite plausible
   explanation of the flaky test failures - since those threads have
   1 second sleep, it's more than likely that the session has been
   created and used by the thread while the teardown has been attempting
   to close all the sessions.
   
   This side effect could also have an effect for other tests that
   were run after - because in a busy test run machine, the side
   effects could propagate further than just to the teardown, so it
   could also explain why sometimes (very rarely) other job tests
   failed with similar errors.
   
   The fix is to join the runner after marking it to be stopped.
   
   Fixes: apache#33323 (Hopefully)

   

   potiuk committed Sep 4, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 03da2dc
   • Browse repository at this point

   Copy the full SHA

   03da2dc View commit details

   Browse the repository at this point in the history