-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and enable test_retry_handling_job #34326
Conversation
Needed to resync dag to db so that scheduler schedules it with num_runs=1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it passes. (The DAGs are cleared after each test in this class so the sync call is fine, albeit not optimal performance-wise.)
@uranusjr What would be a better approach performance-wise? |
close-open for re-trigger full tests |
@Taragolis it seems that tests passed (not sure but I think the steps for building images fail for other reasons) should I close & reopen it several times more to check if it's not flaky? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think better merge it and check if it flakey or not. Previously it was completely broken
Needed to resync dag to db so that scheduler schedules it with num_runs=1 Co-authored-by: daniel.dylag <[email protected]> (cherry picked from commit 1b26cc0)
Needed to resync dag to db so that scheduler schedules it with num_runs=1 Co-authored-by: daniel.dylag <[email protected]> (cherry picked from commit 1b26cc0)
Needed to resync DAG to db as the only DAG so that scheduler schedules it with num_runs=1
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.