Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and enable test_retry_handling_job #34326

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

Bisk1
Copy link
Contributor

@Bisk1 Bisk1 commented Sep 13, 2023

Needed to resync DAG to db as the only DAG so that scheduler schedules it with num_runs=1


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Needed to resync dag to db so that scheduler schedules it with num_runs=1
@boring-cyborg boring-cyborg bot added the area:Scheduler including HA (high availability) scheduler label Sep 13, 2023
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it passes. (The DAGs are cleared after each test in this class so the sync call is fine, albeit not optimal performance-wise.)

@Bisk1
Copy link
Contributor Author

Bisk1 commented Sep 13, 2023

@uranusjr What would be a better approach performance-wise?

@Taragolis Taragolis added the full tests needed We need to run full set of tests for this PR to merge label Sep 13, 2023
@Taragolis
Copy link
Contributor

close-open for re-trigger full tests

@Taragolis Taragolis closed this Sep 13, 2023
@Taragolis Taragolis reopened this Sep 13, 2023
@Bisk1
Copy link
Contributor Author

Bisk1 commented Sep 14, 2023

@Taragolis it seems that tests passed (not sure but I think the steps for building images fail for other reasons) should I close & reopen it several times more to check if it's not flaky?

Copy link
Contributor

@Taragolis Taragolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think better merge it and check if it flakey or not. Previously it was completely broken

@Taragolis Taragolis merged commit 1b26cc0 into apache:main Sep 14, 2023
107 checks passed
@Bisk1 Bisk1 deleted the fix-test_retry_handling_job branch September 14, 2023 11:34
@ephraimbuddy ephraimbuddy added this to the Airflow 2.7.3 milestone Oct 29, 2023
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Oct 29, 2023
ephraimbuddy pushed a commit that referenced this pull request Oct 29, 2023
Needed to resync dag to db so that scheduler schedules it with num_runs=1

Co-authored-by: daniel.dylag <[email protected]>
(cherry picked from commit 1b26cc0)
ephraimbuddy pushed a commit that referenced this pull request Oct 30, 2023
Needed to resync dag to db so that scheduler schedules it with num_runs=1

Co-authored-by: daniel.dylag <[email protected]>
(cherry picked from commit 1b26cc0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Scheduler including HA (high availability) scheduler changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants