Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added command for installing specific pipx packaging version #34772

Closed
wants to merge 2 commits into from
Closed

Added command for installing specific pipx packaging version #34772

wants to merge 2 commits into from

Conversation

theaadya
Copy link
Contributor

@theaadya theaadya commented Oct 5, 2023

I was setting up Airflow with Breeze when I encountered this error:
ModuleNotFoundError: No module named 'airflow_breeze.params'

Came across this PR (#34701) with the same issue, which also provided the fix. Accordingly, I did try to test with the latest main, but the problem wasn't solved.
Was able to resolve it when I ran python3 -m pip install pipx packaging==23.1 (from the commit of the above PR) and then ran the breeze command.

Did anyone else also face this issue? (I installed pipx via brew.)

If significant, I've edited the CONTRIBUTORS_QUICK_START.rst to address this potential error.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Oct 5, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@uranusjr
Copy link
Member

uranusjr commented Oct 5, 2023

pipx is going to make a release with a fix to this issue so this won’t be a problem soon. I don’t think it’s a good idea to fix users on an old packaging version.

@uranusjr uranusjr closed this Oct 5, 2023
@potiuk
Copy link
Member

potiuk commented Oct 8, 2023

Also seems that the PR #34710 fixed the mistake that triggered the error (which was missing __init__.py . So main should work fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants