-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to change the default cron timetable #34851
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
I feel this is a good idea. It may be worthwhile to expand this a bit to be a full “policy” that handles all kinds of non-timetable/dataset inputs, but that could be expanded later, with this maybe retained for convenience or compatibility. |
Yes, linked issue was wrong, I have now fixed it. |
1582b8f
to
5b6206a
Compare
I am not sure how best to unit test this. |
Because conf is not called conf in this file Line 80 in 03a305f
|
6905308
to
5408b5a
Compare
@uranusjr I've responded to all review comments. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
I'm pretty sure the failing test is spurious. I do not have permission to re-run it. |
Neither do we once there is conflict with another PR. You need to rebase and solve the conflicts in order to re-run the tests. |
Co-authored-by: Tzu-ping Chung <[email protected]>
45d52db
to
8852a44
Compare
This is fine, however I think we need to add a bit more education for our users on it. We have about a million configuration parameters and expecting the users to read them and understand them in order to know they can change such a basic behavioud of Airlfow is s mostly wishful thinking. I think this deserve some more important and prominent explanation soemwhere close to "Concepts" - possibly at the "Concept" page itself. I think we should have there a chapter entitled: "How Airflow Schedule Cron-like schedules" - where we should explain how it was, originally and how users can change it to get to more "familiar" scheduling semantics. This is a bit too important change to mention it in only in configuration parameter description IMHO |
I fully agree. Would you be ok with that being a separate PR? |
Sure. That's why I did not |
--------- Co-authored-by: Tzu-ping Chung <[email protected]>
Closes #34695 .
Adds the setting scheduler.legacy_cron_data_intervals with a default of True (CronDataIntervalTimetable). If it is set to False, the CronTriggerTimetable is used for any bare cron strings.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.