Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-2692] Add job_name as templated parameter in AWS Batch Operator #3557

Closed
wants to merge 1 commit into from

Conversation

craigforster
Copy link
Contributor

@craigforster craigforster commented Jun 28, 2018

Make sure you have checked all steps below.

JIRA

  • My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

  • Here are some details about my PR, including screenshots of any UI changes:

When using the AWS Batch Operator, having the job_name field be templated allows easier traceability in the AWS console of which jobs were triggered by which Airflow task instance. In particular, I see using {{ ds_nodash }} as being used heavily in my deployments.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Updated existing test case to check for new field.

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@codecov-io
Copy link

Codecov Report

Merging #3557 into master will decrease coverage by 58.93%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #3557       +/-   ##
==========================================
- Coverage   76.83%   17.9%   -58.94%     
==========================================
  Files         204     204               
  Lines       15485   15485               
==========================================
- Hits        11898    2772     -9126     
- Misses       3587   12713     +9126
Impacted Files Coverage Δ
airflow/operators/generic_transfer.py 0% <0%> (-100%) ⬇️
airflow/operators/sqlite_operator.py 0% <0%> (-100%) ⬇️
...low/example_dags/example_short_circuit_operator.py 0% <0%> (-100%) ⬇️
airflow/example_dags/example_docker_operator.py 0% <0%> (-100%) ⬇️
airflow/api/common/experimental/get_task.py 0% <0%> (-100%) ⬇️
...rflow/api/common/experimental/get_dag_run_state.py 0% <0%> (-100%) ⬇️
airflow/example_dags/docker_copy_data.py 0% <0%> (-100%) ⬇️
airflow/example_dags/example_http_operator.py 0% <0%> (-100%) ⬇️
airflow/www_rbac/widgets.py 0% <0%> (-100%) ⬇️
airflow/www_rbac/validators.py 0% <0%> (-100%) ⬇️
... and 158 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 284dbdb...b64bec7. Read the comment docs.

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfgit asfgit closed this in 7141abd Jun 29, 2018
lxneng pushed a commit to lxneng/incubator-airflow that referenced this pull request Aug 10, 2018
aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
kaxil pushed a commit that referenced this pull request Aug 27, 2019
Closes #3557 from craigforster/master

(cherry picked from commit 7141abd)
kaxil pushed a commit that referenced this pull request Aug 30, 2019
Closes #3557 from craigforster/master

(cherry picked from commit 7141abd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants