Some improvements for Airflow IO code #36259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
reviewed
Dec 17, 2023
potiuk
approved these changes
Dec 17, 2023
|
(and there is missing positional param ). |
bolkedebruin
requested changes
Dec 18, 2023
potiuk
approved these changes
Dec 26, 2023
bolkedebruin
approved these changes
Jan 4, 2024
|
So need to 'resolve' all conversations now... |
abhishekbhakat
pushed a commit
to abhishekbhakat/my_airflow
that referenced
this pull request
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
super.__init__in_AirflowCloudAccessorif we need to provide extra args to_CloudAccessor.fsa cached property inObjectStoreand sets its value in the init if it's provided to avoid managing the caching manually and checking for a provided value in the__init__.