Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assignment of template field in __init__ in SFTPToGCSOperator #36603

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

romsharon98
Copy link
Contributor

related: #36484

change assignment in constructor
move logic to execute

cc: @shahar1


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jan 4, 2024
@romsharon98 romsharon98 changed the title Fix assignment of template field in __init__ in sftp-to-gcs.py Fix assignment of template field in __init__ in SFTPToGCSOperator Jan 4, 2024
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the tests as well?

@romsharon98
Copy link
Contributor Author

Could you update the tests as well?

I rebased and it fixed

@hussein-awala hussein-awala merged commit 8e6bfc2 into apache:main Jan 13, 2024
54 checks passed
@romsharon98 romsharon98 deleted the fix/sftp-to-gcs branch January 14, 2024 07:25
abhishekbhakat pushed a commit to abhishekbhakat/my_airflow that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants