-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deferrable param in FileSensor #36840
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:core-operators
Operators, Sensors and hooks within Core Airflow
area:Triggerer
labels
Jan 17, 2024
Lee-W
reviewed
Jan 17, 2024
pankajastro
requested review from
vatsrahul1001,
phanikumv,
utkarsharma2,
pankajkoti and
Lee-W
January 17, 2024 18:34
Lee-W
reviewed
Jan 18, 2024
Lee-W
approved these changes
Jan 18, 2024
pankajastro
force-pushed
the
add_defferable_to_filesensor
branch
from
January 18, 2024 12:11
231f281
to
8d97041
Compare
phanikumv
reviewed
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need docs and example DAG for this
pankajastro
force-pushed
the
add_defferable_to_filesensor
branch
from
January 18, 2024 12:51
8d97041
to
487cbba
Compare
3 tasks
potiuk
approved these changes
Jan 21, 2024
flacode
pushed a commit
to flacode/airflow
that referenced
this pull request
Jan 22, 2024
* Add deferrable param in FileSensor * Use conf value for as default * Apply review suggestions * Apply review suggestions * Fix docs * Apply review suggestions * Add docs * Fix duplicate task
abhishekbhakat
pushed a commit
to abhishekbhakat/my_airflow
that referenced
this pull request
Mar 5, 2024
* Add deferrable param in FileSensor * Use conf value for as default * Apply review suggestions * Apply review suggestions * Fix docs * Apply review suggestions * Add docs * Fix duplicate task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:core-operators
Operators, Sensors and hooks within Core Airflow
area:Triggerer
type:improvement
Changelog: Improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look like we have trigger implementation for the filesystem but the defer mechanism is missing in the sensor. this PR introduce
deferrable
param in FileSensor.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.