Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deferrable param in FileSensor #36840

Merged
merged 8 commits into from
Jan 21, 2024

Conversation

pankajastro
Copy link
Member

Look like we have trigger implementation for the filesystem but the defer mechanism is missing in the sensor. this PR introduce deferrable param in FileSensor.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:core-operators Operators, Sensors and hooks within Core Airflow area:Triggerer labels Jan 17, 2024
airflow/triggers/file.py Outdated Show resolved Hide resolved
airflow/sensors/filesystem.py Outdated Show resolved Hide resolved
airflow/sensors/filesystem.py Outdated Show resolved Hide resolved
airflow/sensors/filesystem.py Outdated Show resolved Hide resolved
airflow/sensors/filesystem.py Outdated Show resolved Hide resolved
Copy link
Contributor

@phanikumv phanikumv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need docs and example DAG for this

@potiuk potiuk merged commit d48985c into apache:main Jan 21, 2024
55 checks passed
@pankajastro pankajastro deleted the add_defferable_to_filesensor branch January 22, 2024 04:00
flacode pushed a commit to flacode/airflow that referenced this pull request Jan 22, 2024
* Add deferrable param in FileSensor

* Use conf value for as default

* Apply review suggestions

* Apply review suggestions

* Fix docs

* Apply review suggestions

* Add docs

* Fix duplicate task
@ephraimbuddy ephraimbuddy added this to the Airflow 2.9.0 milestone Feb 19, 2024
@ephraimbuddy ephraimbuddy added the type:improvement Changelog: Improvements label Feb 19, 2024
abhishekbhakat pushed a commit to abhishekbhakat/my_airflow that referenced this pull request Mar 5, 2024
* Add deferrable param in FileSensor

* Use conf value for as default

* Apply review suggestions

* Apply review suggestions

* Fix docs

* Apply review suggestions

* Add docs

* Fix duplicate task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow area:Triggerer type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants