Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix providers validation in check_files.py after switch to the hatch builds #36921

Conversation

Taragolis
Copy link
Contributor

related: #36902

Just figure out that naming also affected to providers packages

breeze release-management prepare-provider-packages microsoft.azure google amazon --version-suffix-for-pypi dev0 --package-format both
Good version of Docker: 24.0.7.
Good version of docker-compose: 2.23.3
...

Successfully built packages!


Packages available in dist:

apache_airflow_providers_amazon-8.16.0.dev0-py3-none-any.whl
apache_airflow_providers_amazon-8.16.0.dev0.tar.gz
apache_airflow_providers_google-10.13.1.dev0-py3-none-any.whl
apache_airflow_providers_google-10.13.1.dev0.tar.gz
apache_airflow_providers_microsoft_azure-8.5.1.dev0-py3-none-any.whl
apache_airflow_providers_microsoft_azure-8.5.1.dev0.tar.gz

I think that it not required to change check_upgrade_check and maybe even better to remove this option from the file

airflow/dev/check_files.py

Lines 146 to 157 in 98fb11b

def check_upgrade_check(files: list[str], version: str):
print(f"Checking upgrade_check for version {version}:\n")
version = strip_rc_suffix(version)
expected_files = expand_name_variations(
[
f"apache-airflow-upgrade-check-{version}-bin.tar.gz",
f"apache-airflow-upgrade-check-{version}-source.tar.gz",
f"apache_airflow_upgrade_check-{version}-py2.py3-none-any.whl",
]
)
return check_all_files(expected_files=expected_files, actual_files=files)


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@hussein-awala hussein-awala merged commit db767f0 into apache:main Jan 19, 2024
80 checks passed
@Taragolis Taragolis deleted the fix-check-files-hatch-builds-naming-providers branch January 20, 2024 00:27
flacode pushed a commit to flacode/airflow that referenced this pull request Jan 22, 2024
potiuk pushed a commit that referenced this pull request Feb 7, 2024
@potiuk potiuk added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Feb 8, 2024
@potiuk potiuk added this to the Airflow 2.8.2 milestone Feb 8, 2024
ephraimbuddy pushed a commit that referenced this pull request Feb 22, 2024
abhishekbhakat pushed a commit to abhishekbhakat/my_airflow that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants