-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump min version of Alembic to 1.13.1 #36928
Conversation
There are some errors for users who still use sqlalchemy 1, where Alembic 1.13.0 wrongly marks some migration as SqlAlchemy 2+ Fixes: apache#36912
Maybe we just need to exclude the version which has buggy behavior in SA 1.4? |
Thought about it and I generally prefer to bump it up in this case. Alembic has generally one purpose - keep our migrations working. And there is rather low probability someone will need a lower version of alembic for something else in airflow environment. And alembic has very few dependencies and they have low limits in this new version so no risk of other conflicts. I'd prefer in such cases to bump min versions with lower-binding. This has the nice side effect of people experiencing less bugs and security problems - and risks are IMHO rather low. |
There are some errors for users who still use sqlalchemy 1, where Alembic 1.13.0 wrongly marks some migration as SqlAlchemy 2+ Fixes: apache#36912
There are some errors for users who still use sqlalchemy 1, where Alembic 1.13.0 wrongly marks some migration as SqlAlchemy 2+ Fixes: apache#36912
There are some errors for users who still use sqlalchemy 1, where Alembic 1.13.0 wrongly marks some migration as SqlAlchemy 2+
Fixes: #36912
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.