-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable dryrun autofetch for ClearInstance and MarkInstance #36941
Merged
bbovenzi
merged 1 commit into
apache:main
from
im-perativa:36119_audit_log_clear_task_bug
Jan 22, 2024
Merged
Disable dryrun autofetch for ClearInstance and MarkInstance #36941
bbovenzi
merged 1 commit into
apache:main
from
im-perativa:36119_audit_log_clear_task_bug
Jan 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set useQuery to be enabled after action button is clicked instead of automatically closes issue apache#36119
im-perativa
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
January 22, 2024 02:46
boring-cyborg
bot
added
area:UI
Related to UI/UX. For Frontend Developers.
area:webserver
Webserver related Issues
labels
Jan 22, 2024
dirrao
suggested changes
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Do we have test cases for these files. If yes, then can we add the test cases for this change?
@dirrao I'm not sure if we have test cases for these files as these are UI modification without change to the connexion API. cmiiw |
bbovenzi
approved these changes
Jan 22, 2024
flacode
pushed a commit
to flacode/airflow
that referenced
this pull request
Jan 22, 2024
set useQuery to be enabled after action button is clicked instead of automatically closes issue apache#36119
2 tasks
jedcunningham
pushed a commit
that referenced
this pull request
Feb 9, 2024
potiuk
pushed a commit
that referenced
this pull request
Feb 13, 2024
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 22, 2024
68 tasks
abhishekbhakat
pushed a commit
to abhishekbhakat/my_airflow
that referenced
this pull request
Mar 5, 2024
set useQuery to be enabled after action button is clicked instead of automatically closes issue apache#36119
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:UI
Related to UI/UX. For Frontend Developers.
area:webserver
Webserver related Issues
type:bug-fix
Changelog: Bug Fixes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR set
useQuery
to be enabled after action button(Clear task/Mark state as) is clicked instead of automatically on render to reduce dry run api calls and prevent unintended audit logs record when clicking task in grid.closes issue #36119
36941.mp4
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.