Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Teradata Provider #36953

Merged
merged 44 commits into from
Feb 15, 2024
Merged

Add Teradata Provider #36953

merged 44 commits into from
Feb 15, 2024

Conversation

sc250072
Copy link
Contributor

Initial Implementation of Airflow Teradata Provider for Teradata - complete cloud analytics and data platform. As part of initial release, Added below functionalities.

  1. Teradata Hook
  2. Teradata Operator
  3. Teradata to Teradata Transfer Operator.

Added required documentation, unit and system tests for Teradata Provider changes.

With this PR:

  1. New Airflow Provider for Teradata will be released.

Teradata Provider System Test Health Board:

https://teradata.github.io/airflow/

Teradata Provider documentation build status: https://github.com/Teradata/airflow/actions/runs/7613734774

Teradata Provider static checks status: https://github.com/Teradata/airflow/actions/runs/7613748694/job/20734385279


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

…lytics and data platform

Implemented new airflow provider with Hook, Operator and Transfer Operator
@sunilkmallam
Copy link

Hi Airflow Community,

We've sent a proposal for Teradata being Airflow's new community provider. After 72 hours of voting, we have 9 positive votes (4 binding and 5 non-binding).
Here's a link to the voting thread.

Please review our PR and let us know if there's anything else you'd need from us.

Thanks,
Sunil Mallam (Teradata)

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks clean! I will run the tests, let's wait for them

.github/CODEOWNERS Outdated Show resolved Hide resolved
tests/providers/teradata/hooks/test_teradata.py Outdated Show resolved Hide resolved
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review for now

@sc250072 sc250072 requested a review from eladkal January 24, 2024 16:21
@sc250072
Copy link
Contributor Author

Partial review for now

Addressed the review comments.

@flolas
Copy link
Contributor

flolas commented Jan 24, 2024

Hi @SatishChGit,
I think that many long-time Teradata users rely on BTEQ queries. How about in the future integrating a TtuHook (Teradata tools and utilities) for fastexport/fastload/bteq in our provider? I have a working version with tests here: https://github.com/flolas/apache-airflow-providers-teradata.

@sc250072
Copy link
Contributor Author

integrating

Thank you for this. We will check the possibility and will add in our roadmap.

@sunilkmallam
Copy link

Partial review for now

Addressed the review comments.

Hi @eladkal, have you had a chance to review the changes we did?

Copy link
Contributor

@josh-fell josh-fell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work here! A few changes needed notwithstanding the example DAG question.

airflow/providers/teradata/hooks/teradata.py Show resolved Hide resolved
airflow/providers/teradata/hooks/teradata.py Outdated Show resolved Hide resolved
airflow/providers/teradata/operators/teradata.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
tests/providers/teradata/hooks/test_teradata.py Outdated Show resolved Hide resolved
tests/providers/teradata/operators/test_teradata.py Outdated Show resolved Hide resolved
airflow/providers/teradata/hooks/teradata.py Outdated Show resolved Hide resolved
@eladkal eladkal changed the title Airflow Teradata Provider: Initial implementation of Airflow Teradata Provider Add Teradata Provider Feb 2, 2024
commit ade9ce3
Author: SatishChGit <[email protected]>
Date:   Wed Feb 14 01:04:46 2024 -0800

    Redesigned teradatatoteradataoperator by removing private method
@sunilkmallam
Copy link

@airflow team, just following up on the changes we made. Could someone please review them?

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sc250072
Copy link
Contributor Author

Solid work here! A few changes needed notwithstanding the example DAG question.

Addressed all review comments.

Copy link
Contributor

@josh-fell josh-fell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A very minor comment for code snippet formatting in the docs, but that definitely doesn't deter from the work here.

@sc250072
Copy link
Contributor Author

LGTM! A very minor comment for code snippet formatting in the docs, but that definitely doesn't deter from the work here.

Thank you for the review. Committed suggested change.

@potiuk potiuk merged commit c41794d into apache:main Feb 15, 2024
84 checks passed
Copy link

boring-cyborg bot commented Feb 15, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@potiuk
Copy link
Member

potiuk commented Feb 15, 2024

🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉

@josh-fell
Copy link
Contributor

Nice work @SatishChGit, congrats!

@sunilkmallam
Copy link

Thank you, everyone, for your support! We truly appreciate it!

@eladkal
Copy link
Contributor

eladkal commented Feb 15, 2024

🎉 🎉

Great work!

@sc250072
Copy link
Contributor Author

sc250072 commented Feb 16, 2024

Thank you every one for your support!. When is the airflow next release. After next airflow release, hope teradata provider will be listed at https://airflow.apache.org/docs/#active-providers.

@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Feb 19, 2024
@kaxil
Copy link
Member

kaxil commented Feb 21, 2024

Thank you every one for your support!. When is the airflow next release. After next airflow release, hope teradata provider will be listed at https://airflow.apache.org/docs/#active-providers.

It will be in the next wave of providers for the release, or we can cut an ad-hoc one cc @eladkal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) provider:teradata
Projects
None yet
Development

Successfully merging this pull request may close these issues.