Use generic utils for cleanup db and operate with temp objects in TestXcomObjectStoreBackend #37166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taragolis
added
the
type:misc/internal
Taragolis
commented
Feb 4, 2024
dirrao
approved these changes
Feb 5, 2024
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
Taragolis
force-pushed
the
test-xcom-io-use-common-fixtures
branch
from
111265d
to
2756e0b
Compare
Taragolis
added
changelog:skip
potiuk
approved these changes
Mar 22, 2024
…tXcomObjectStoreBackend
Taragolis
force-pushed
the
test-xcom-io-use-common-fixtures
branch
from
2756e0b
to
c65aa59
Compare
|
This PR better merge (and possibly rebase) after #38608 |
uranusjr
approved these changes
Mar 29, 2024
potiuk
approved these changes
Mar 29, 2024
potiuk
approved these changes
Mar 30, 2024
|
Turns out this got merged first so I rebased #38608 instead. I think I did it right? @Taragolis |
mathiaHT
pushed a commit
to mathiaHT/airflow
that referenced
this pull request
Apr 4, 2024
…tXcomObjectStoreBackend (apache#37166) * Use generic utils for cleanup db and operate with temp objects in TestXcomObjectStoreBackend * Return back @pytest.mark.db_test markers * Use global marker on module * DRY: Use create_task_instance_of_operator fixture
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
…tXcomObjectStoreBackend (apache#37166) * Use generic utils for cleanup db and operate with temp objects in TestXcomObjectStoreBackend * Return back @pytest.mark.db_test markers * Use global marker on module * DRY: Use create_task_instance_of_operator fixture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use pytest temporary directory structure instead of hardcoded
/tmp/xcomUse
tests.test_utils.dbfor cleanup test DB.Avoid to directly change configuration, instead of that use
conf_varsfixture^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.