Partially enable D100, D102, D103 and D104
#37469
Conversation
| from __future__ import annotations | ||
|
|
||
| import warnings |
There was a problem hiding this comment.
@potiuk , pre-commit hooks reformatted this module after I moved doc string to Line 17 from Line 48. Should I revert this change?
I thought instead of merging E*s and D*s , like you mentioned, I could just fix the conflicts. Reason being, I felt E*s (at least E402) is supposed to be ignored
There was a problem hiding this comment.
@potiuk I guess this license notice might be removed because it is already listed in https://github.com/apache/airflow/blob/main/3rd-party-licenses/LICENSE-flask-kerberos.txt
rawwar
changed the title
D100, D101, D102, D103 and D104D100, D102, D103 and D104
Signed-off-by: kalyanr <[email protected]>
Signed-off-by: kalyanr <[email protected]>
There was a problem hiding this comment.
And also think it listed in 3rd-party-licenses: https://github.com/apache/airflow/blob/main/3rd-party-licenses/LICENSE-hue.txt
Added in #438
Source
https://github.com/cloudera/hue/blob/master/desktop/core/src/desktop/kt_renewer.py
There was a problem hiding this comment.
So, is it safe to remove from the modules? If so, I can check for all the modules where E402 is ignored and probably move the license text to a separate license file.
|
conflicts to solve? |
|
I won't be able to work on this for a week or two. My laptop got damaged. I'll continue working on this once I get back my laptop. Thanks! |
related: #10742
Enabled D100 to D104 partially by adding ignores to pyproject.toml.
Also included few fixes which were causing conflictin keys w.r.t
E* lint issues.