Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix credentials error for S3ToGCSOperator trigger #37518

Conversation

korolkevich
Copy link
Contributor

@korolkevich korolkevich commented Feb 18, 2024

related: #37331
Add gcd_conn_id for S3ToGCSOperator trigger

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Feb 18, 2024
Copy link

boring-cyborg bot commented Feb 18, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@eladkal eladkal force-pushed the fix-credentials-error-for-S3ToGCSOperator-trigger branch from d20ab3e to 4f2583a Compare March 25, 2024 18:21
@eladkal eladkal force-pushed the fix-credentials-error-for-S3ToGCSOperator-trigger branch from 4f2583a to e8e1a62 Compare April 1, 2024 08:12
@eladkal eladkal merged commit 13e9a0d into apache:main Apr 1, 2024
40 checks passed
Copy link

boring-cyborg bot commented Apr 1, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

idantepper pushed a commit to idantepper/airflow that referenced this pull request Apr 3, 2024
* Fix credentials error for S3ToGCSOperator trigger

* fix: safe create StorageTransferServiceAsyncClient()

* fix: test, style, some bugs
idantepper pushed a commit to idantepper/airflow that referenced this pull request Apr 3, 2024
* Fix credentials error for S3ToGCSOperator trigger

* fix: safe create StorageTransferServiceAsyncClient()

* fix: test, style, some bugs
mathiaHT pushed a commit to mathiaHT/airflow that referenced this pull request Apr 4, 2024
* Fix credentials error for S3ToGCSOperator trigger

* fix: safe create StorageTransferServiceAsyncClient()

* fix: test, style, some bugs
utkarsharma2 pushed a commit to astronomer/airflow that referenced this pull request Apr 22, 2024
* Fix credentials error for S3ToGCSOperator trigger

* fix: safe create StorageTransferServiceAsyncClient()

* fix: test, style, some bugs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants