templated fields logic checks for cloud_storage_transfer_service

[okirialbert]

---

The PR fixes assignment of parameters in constructor initialization for the google cloud_storage_transfer_service ensuring templated fields' parameters correspond to constructor initialization.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

[okirialbert]

@romsharon98 Kindly review.

[Taragolis]

And also required fix failing tests

[romsharon98]

can u explain the purpose of this PR?
In this issue #36484
cloud_storage_transfer_service.py is shown as not implemented but when running pre-commit on it it looks like it already taken care.
also in the pre-commit-config the file is not excluded (meaning template field works)
maybe someone has fixed it but not related it to the story.

[eladkal]

The list of files that needs to be fixed is in:

airflow/.pre-commit-config.yaml

Lines 328 to 335 in e5688b9

	^airflow\/providers\/google\/cloud\/operators\/bigquery\.py$|
	^airflow\/providers\/amazon\/aws\/transfers\/gcs_to_s3\.py$|
	^airflow\/providers\/databricks\/operators\/databricks\.py$|
	^airflow\/providers\/google\/cloud\/transfers\/bigquery_to_mysql\.py$|
	^airflow\/providers\/amazon\/aws\/transfers\/redshift_to_s3\.py$|
	^airflow\/providers\/google\/cloud\/operators\/compute\.py$|
	^airflow\/providers\/amazon\/aws\/operators\/emr\.py$|
	^airflow\/providers\/amazon\/aws\/operators\/eks\.py$

Thus like what @romsharon98 mentioned. i am not sure how this PR relates to #36484 ?
Can you explain?

[okirialbert]

The service had minor deprecating changes I opted to take care of that were relating to #36484

[Taragolis]

Just wondering, anyone noticed this lines above of the changes 🙄 😵‍💫

airflow/airflow/providers/google/cloud/operators/cloud_storage_transfer_service.py

Lines 549 to 556 in 2bcfe54

	if request_filter is None:
	if "filter" in kwargs:
	request_filter = kwargs["filter"]
	AirflowProviderDeprecationWarning(
	"Use 'request_filter' instead 'filter' to pass the argument."
	)
	else:
	TypeError("__init__() missing 1 required positional argument: 'request_filter'")

[okirialbert]

Hey @Taragolis, I presumed the already implemented filter check ensures parameter backward compatibility and your suggestion accounts for property declaration

[okirialbert]

Hi @Taragolis should I add your code, replace or leave the changes as they are?

[eladkal]

@okirialbert can you rebase and fix conflicts?

[okirialbert]

@eladkal yeah sure

[shahar1]

LGTM with small comment :)

[eladkal]

Needs rebase and resolve conflicts