-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify ssl verification in druid operator #37673
Modify ssl verification in druid operator #37673
Conversation
…m:danielbe11/airflow into modify-ssl-verification-in-druid-operator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the test case for this change?
@dirrao the backwards compatibility and get_verify method are tested, I will add a small test for 'conn' method today |
I have added |
* Use cached_property for get_connection to avoid calling >1 * Get ca bundle path from connection config if not verifying ssl * Add type checking check * Add tests * Fix lint and add documentation * Use default * Final tidy * Add log for when using CA bundle * Add test_conn_property --------- Co-authored-by: Daniel Bell <[email protected]>
* Use cached_property for get_connection to avoid calling >1 * Get ca bundle path from connection config if not verifying ssl * Add type checking check * Add tests * Fix lint and add documentation * Use default * Final tidy * Add log for when using CA bundle * Add test_conn_property --------- Co-authored-by: Daniel Bell <[email protected]>
extra
property of the Druid connection is checked forverify
key which can be set as the path to CA bundle.self.get_connection(self.druid_ingest_conn_id)
which is called >1 times.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.