Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade google-ads version #37787

Merged

Conversation

molcay
Copy link
Contributor

@molcay molcay commented Feb 29, 2024

This PR is about upgrading the google-ads version which is a dependency for google providers


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Feb 29, 2024
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the motivation?
V16 is very new and v15 was released last year.
As long as v15 is not EOL I dont think we should change the default

@molcay
Copy link
Contributor Author

molcay commented Feb 29, 2024

Hi @eladkal,

Since we are using the google-ads>=22.1 as a dependency it will install the latest version when you have the new installation. So we are just trying to keep it up-to-date. Also google-ads v23.1 had all the previous versions of the API, thus they are still accessible, and if users specify default API version explicitly they won't notice any changes.

For this part, we are using this part just for type checking.

For this part, we are setting default to latest API version. Developer can use our version if they want, by passing the version.

Also, here is the latest diff for v15 and v16. It does not have any breaking changes.

Copy link

@pedro-klein-desco pedro-klein-desco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link new version Google Ads Doc

@potiuk
Copy link
Member

potiuk commented Mar 5, 2024

Yeah. It's better to preemptively bump Ads version.

@potiuk potiuk merged commit 0c09338 into apache:main Mar 5, 2024
110 checks passed
@potiuk
Copy link
Member

potiuk commented Mar 5, 2024

They tend to deprecate stuff faster than everyone else

@utkarsharma2 utkarsharma2 added this to the Airflow 2.8.3 milestone Mar 6, 2024
@utkarsharma2 utkarsharma2 added type:improvement Changelog: Improvements type:misc/internal Changelog: Misc changes that should appear in change log and removed type:improvement Changelog: Improvements labels Mar 6, 2024
ephraimbuddy pushed a commit that referenced this pull request Mar 6, 2024
(cherry picked from commit 0c09338)
ephraimbuddy pushed a commit that referenced this pull request Mar 6, 2024
(cherry picked from commit 0c09338)
@ephraimbuddy ephraimbuddy removed this from the Airflow 2.8.3 milestone Mar 7, 2024
@ephraimbuddy ephraimbuddy added changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) and removed type:misc/internal Changelog: Misc changes that should appear in change log labels Mar 20, 2024
@molcay molcay deleted the feat/upgrade-google-ads-api-version branch April 3, 2024 09:19
utkarsharma2 pushed a commit to astronomer/airflow that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants