-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade google-ads version #37787
Upgrade google-ads version #37787
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the motivation?
V16 is very new and v15 was released last year.
As long as v15 is not EOL I dont think we should change the default
Hi @eladkal, Since we are using the For this part, we are using this part just for type checking. For this part, we are setting default to latest API version. Developer can use our version if they want, by passing the version. Also, here is the latest diff for v15 and v16. It does not have any breaking changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link new version Google Ads Doc
Yeah. It's better to preemptively bump Ads version. |
They tend to deprecate stuff faster than everyone else |
(cherry picked from commit 0c09338)
(cherry picked from commit 0c09338)
This PR is about upgrading the
google-ads
version which is a dependency forgoogle
providers^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.